Demangle explicitly named object parameters #299
Draft
+97
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a patch that allows for the ability to demangle code like:
```
struct Foo {
void bar(this Foo && self);
};
```
An example mangling is `_ZNH1S3fooES_` which then demangles to
`S::foo(this S)`.
The proposal can be found here: itanium-cxx-abi/cxx-abi#148
Saldivarcher
force-pushed
the
user/saldivarcher/feature/explicit-object-member
branch
from
6e07982 to
d1b6b2f
Compare
|
@khuey this is something I have in the works, what do you think of it? Let me know what can be cleaned up, or done in a better manner. |
|
Is this a mere proposal at this stage or are gcc/clang actually using this? |
|
Clang is using it: llvm/llvm-project#72881 |
khuey
requested changes
Jun 2, 2025
| /// | ||
| /// ```text | ||
| /// <ref-qualifier> ::= R # & ref-qualifier | ||
| /// ::= O # && ref-qualifier |
There was a problem hiding this comment.
The description here needs to be updated.
| @@ -1938,19 +1947,28 @@ impl<'a> GetLeafName<'a> for UnscopedTemplateName { | |||
| /// ```text | |||
| /// <nested-name> ::= N [<CV-qualifiers>] [<ref-qualifier>] <prefix> <unqualified-name> E | |||
| /// ::= N [<CV-qualifiers>] [<ref-qualifier>] <template-prefix> <template-args> E | |||
| /// ::= N H <prefix> <unqualified-name> E | |||
| /// ::= N H <template-prefix> <template-args> E | |||
There was a problem hiding this comment.
Since these variants don't admit the CvQualifiers or RefQualifier I think it would be better to create new NestedName variants for them.
| ctx.is_template_prefix_in_nested_name = true; | ||
| p.demangle(ctx, scope)?; | ||
| ctx.is_template_prefix_in_nested_name = false; | ||
| } | ||
| } | ||
|
|
||
| if self.has_explicit_obj_param() { | ||
| ctx.is_explicit_obj_param = true; |
There was a problem hiding this comment.
If you're going to track this state on the context it will have to be cleared somewhere, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch that allows for the ability to demangle code like:
An example mangling is
_ZNH1S3fooES_which then demangles toS::foo(this S).The proposal can be found here: itanium-cxx-abi/cxx-abi#148